refactor: remove confusing code practices (#87)

* Prefer `c ? x : y` over `c && x || y`

* Avoid unnecessary asssignment expressions

* Prefer switch statements over object lookup tables

* Add an .editorconfig

* Fix style issues

* Fix mentioned issues

Co-authored-by: bob <bob.varioa@gmail.com>
This commit is contained in:
Bob Varioa
2022-07-01 17:37:59 -05:00
committed by GitHub
parent 3e2b932844
commit 0a851bde31
38 changed files with 418 additions and 243 deletions

View File

@@ -7,16 +7,18 @@ class MusicCarouselShelfBasicHeader {
type = 'MusicCarouselShelfBasicHeader';
constructor(data) {
data.strapline &&
(this.strapline = new Text(data.strapline).toString());
if (data.strapline) {
this.strapline = new Text(data.strapline).toString()
}
this.title = new Text(data.title).toString();
// this.label = data.accessibilityData.accessibilityData.label;
// ^^ redundant?
data.thumbnail &&
(this.thumbnail = Thumbnail.fromResponse(data.thumbnail.musicThumbnailRenderer.thumbnail));
if (data.thumbnail) {
this.thumbnail = Thumbnail.fromResponse(data.thumbnail.musicThumbnailRenderer.thumbnail)
}
}
}