PascalCase -> snake_case for consistency with the rest of the codebase.

src/nnue/features/p.cpp

@@ -10,26 +10,30 @@ namespace Eval::NNUE::Features {
     }
 
     // Find the index of the feature quantity from the king position and PieceSquare
-    inline IndexType P::MakeIndex(
+    inline IndexType P::make_index(
         Color perspective, Square s, Piece pc) {
         return IndexType(orient(perspective, s) + kpp_board_index[pc][perspective]);
     }
 
     // Get a list of indices with a value of 1 among the features
-    void P::AppendActiveIndices(
-        const Position& pos, Color perspective, IndexList* active) {
+    void P::append_active_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* active) {
 
         Bitboard bb = pos.pieces() & ~pos.pieces(KING);
         while (bb) {
             Square s = pop_lsb(&bb);
-            active->push_back(MakeIndex(perspective, s, pos.piece_on(s)));
+            active->push_back(make_index(perspective, s, pos.piece_on(s)));
         }
     }
 
     // Get a list of indices whose values ​​have changed from the previous one in the feature quantity
-    void P::AppendChangedIndices(
-        const Position& pos, Color perspective,
-        IndexList* removed, IndexList* added) {
+    void P::append_changed_indices(
+        const Position& pos,
+        Color perspective,
+        IndexList* removed,
+        IndexList* added) {
 
         const auto& dp = pos.state()->dirtyPiece;
         for (int i = 0; i < dp.dirty_num; ++i) {
@@ -39,10 +43,10 @@ namespace Eval::NNUE::Features {
               continue;
 
             if (dp.from[i] != SQ_NONE)
-              removed->push_back(MakeIndex(perspective, dp.from[i], pc));
+              removed->push_back(make_index(perspective, dp.from[i], pc));
 
             if (dp.to[i] != SQ_NONE)
-              added->push_back(MakeIndex(perspective, dp.to[i], pc));
+              added->push_back(make_index(perspective, dp.to[i], pc));
         }
     }