jirayu_sri/stockfish
1
0
Fork 0
mirror of https://github.com/official-stockfish/Stockfish.git synced 2026-07-22 12:47:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Compiler Warning

Browse Source 
Only the one on line 158 is actually required but doesn't hurt to add constexpr where applicable here.

Warning was

"comparison of unsigned expression in '< 0' is always false"

closes https://github.com/official-stockfish/Stockfish/pull/6530

No functional change
This commit is contained in:
Disservin
2026-01-10 15:34:37 +01:00
committed by Joost VandeVondele
parent d39bfb61a2
commit 5d5e795746
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/nnue/nnue_feature_transformer.h
+9 -9
View File
@@ -132,7 +132,7 @@ class FeatureTransformer {
permute<16>(biases, PackusEpi16Order); permute<16>(biases, PackusEpi16Order);
permute<16>(weights, PackusEpi16Order); permute<16>(weights, PackusEpi16Order);
if (UseThreats) if constexpr (UseThreats)
permute<8>(threatWeights, PackusEpi16Order); permute<8>(threatWeights, PackusEpi16Order);
} }
@@ -140,7 +140,7 @@ class FeatureTransformer {
permute<16>(biases, InversePackusEpi16Order); permute<16>(biases, InversePackusEpi16Order);
permute<16>(weights, InversePackusEpi16Order); permute<16>(weights, InversePackusEpi16Order);
if (UseThreats) if constexpr (UseThreats)
permute<8>(threatWeights, InversePackusEpi16Order); permute<8>(threatWeights, InversePackusEpi16Order);
} }
@@ -155,7 +155,7 @@ class FeatureTransformer {
bool read_parameters(std::istream& stream) { bool read_parameters(std::istream& stream) {
read_leb_128(stream, biases); read_leb_128(stream, biases);
if (UseThreats) if constexpr (UseThreats)
{ {
read_little_endian<ThreatWeightType>(stream, threatWeights.data(), read_little_endian<ThreatWeightType>(stream, threatWeights.data(),
ThreatInputDimensions * HalfDimensions); ThreatInputDimensions * HalfDimensions);
@@ -171,7 +171,7 @@ class FeatureTransformer {
permute_weights(); permute_weights();
if (!UseThreats) if constexpr (!UseThreats)
scale_weights(true); scale_weights(true);
return !stream.fail(); return !stream.fail();
@@ -183,12 +183,12 @@ class FeatureTransformer {
copy->unpermute_weights(); copy->unpermute_weights();
if (!UseThreats) if constexpr (!UseThreats)
copy->scale_weights(false); copy->scale_weights(false);
write_leb_128<BiasType>(stream, copy->biases); write_leb_128<BiasType>(stream, copy->biases);
if (UseThreats) if constexpr (UseThreats)
{ {
write_little_endian<ThreatWeightType>(stream, copy->threatWeights.data(), write_little_endian<ThreatWeightType>(stream, copy->threatWeights.data(),
ThreatInputDimensions * HalfDimensions); ThreatInputDimensions * HalfDimensions);
@@ -242,7 +242,7 @@ class FeatureTransformer {
auto psqt = auto psqt =
(psqtAccumulation[perspectives[0]][bucket] - psqtAccumulation[perspectives[1]][bucket]); (psqtAccumulation[perspectives[0]][bucket] - psqtAccumulation[perspectives[1]][bucket]);
if (UseThreats) if constexpr (UseThreats)
{ {
const auto& threatPsqtAccumulation = const auto& threatPsqtAccumulation =
(threatAccumulatorState.acc<HalfDimensions>()).psqtAccumulation; (threatAccumulatorState.acc<HalfDimensions>()).psqtAccumulation;
@@ -334,7 +334,7 @@ class FeatureTransformer {
#else #else
6; 6;
#endif #endif
if (UseThreats) if constexpr (UseThreats)
{ {
const vec_t* tin0 = const vec_t* tin0 =
reinterpret_cast<const vec_t*>(&(threatAccumulation[perspectives[p]][0])); reinterpret_cast<const vec_t*>(&(threatAccumulation[perspectives[p]][0]));
@@ -386,7 +386,7 @@ class FeatureTransformer {
BiasType sum1 = BiasType sum1 =
accumulation[static_cast<int>(perspectives[p])][j + HalfDimensions / 2]; accumulation[static_cast<int>(perspectives[p])][j + HalfDimensions / 2];
if (UseThreats) if constexpr (UseThreats)
{ {
BiasType sum0t = threatAccumulation[static_cast<int>(perspectives[p])][j + 0]; BiasType sum0t = threatAccumulation[static_cast<int>(perspectives[p])][j + 0];
BiasType sum1t = BiasType sum1t =