jirayu_sri/stockfish
1
0
Fork 0
mirror of https://github.com/official-stockfish/Stockfish.git synced 2026-07-22 12:47:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary memset(), memcpy() from NetworkArcitecture::propagate()

Browse Source 
Since https://github.com/official-stockfish/Stockfish/pull/6938 this is no longer needed.

closes https://github.com/official-stockfish/Stockfish/pull/6950

No functional change
This commit is contained in:
mstembera
2026-07-06 11:38:27 +02:00
committed by Joost VandeVondele
parent 2cbf39f845
commit eca43a97ef
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/nnue/nnue_architecture.h
+2 -11
View File
@@ -22,7 +22,6 @@
#define NNUE_ARCHITECTURE_H_INCLUDED #define NNUE_ARCHITECTURE_H_INCLUDED
#include <cstdint> #include <cstdint>
#include <cstring>
#include <iosfwd> #include <iosfwd>
#include "features/half_ka_v2_hm.h" #include "features/half_ka_v2_hm.h"
@@ -104,27 +103,19 @@ struct NetworkArchitecture {
alignas(CacheLineSize) typename decltype(fc_0)::OutputBuffer fc_0_out; alignas(CacheLineSize) typename decltype(fc_0)::OutputBuffer fc_0_out;
alignas(CacheLineSize) typename decltype(ac_sqr_0)::OutputType alignas(CacheLineSize) typename decltype(ac_sqr_0)::OutputType
concat_buffer[ceil_to_multiple<IndexType>(FC_0_OUTPUTS * 2 + FC_1_OUTPUTS * 2, 32)]; concat_buffer[ceil_to_multiple<IndexType>(FC_0_OUTPUTS * 2 + FC_1_OUTPUTS * 2, 32)];
alignas(CacheLineSize) typename decltype(ac_0)::OutputBuffer ac_0_out;
alignas(CacheLineSize) typename decltype(fc_1)::OutputBuffer fc_1_out; alignas(CacheLineSize) typename decltype(fc_1)::OutputBuffer fc_1_out;
alignas(CacheLineSize) typename decltype(ac_1)::OutputBuffer ac_1_out;
alignas(CacheLineSize) typename decltype(fc_2)::OutputBuffer fc_2_out; alignas(CacheLineSize) typename decltype(fc_2)::OutputBuffer fc_2_out;
Buffer() { std::memset(concat_buffer, 0, sizeof(concat_buffer)); }
}; };
Buffer buffer; Buffer buffer;
fc_0.propagate(transformedFeatures, buffer.fc_0_out, nnzInfo); fc_0.propagate(transformedFeatures, buffer.fc_0_out, nnzInfo);
ac_sqr_0.propagate(buffer.fc_0_out, buffer.concat_buffer); ac_sqr_0.propagate(buffer.fc_0_out, buffer.concat_buffer);
ac_0.propagate(buffer.fc_0_out, buffer.ac_0_out); ac_0.propagate(buffer.fc_0_out, buffer.concat_buffer + FC_0_OUTPUTS);
std::memcpy(buffer.concat_buffer + FC_0_OUTPUTS, buffer.ac_0_out,
FC_0_OUTPUTS * sizeof(typename decltype(ac_0)::OutputType));
fc_1.propagate(buffer.concat_buffer, buffer.fc_1_out); fc_1.propagate(buffer.concat_buffer, buffer.fc_1_out);
ac_sqr_1.propagate(buffer.fc_1_out, buffer.concat_buffer + FC_0_OUTPUTS * 2); ac_sqr_1.propagate(buffer.fc_1_out, buffer.concat_buffer + FC_0_OUTPUTS * 2);
ac_1.propagate(buffer.fc_1_out, buffer.ac_1_out); ac_1.propagate(buffer.fc_1_out, buffer.concat_buffer + FC_0_OUTPUTS * 2 + FC_1_OUTPUTS);
std::memcpy(buffer.concat_buffer + FC_0_OUTPUTS * 2 + FC_1_OUTPUTS, buffer.ac_1_out,
FC_1_OUTPUTS * sizeof(typename decltype(ac_1)::OutputType));
fc_2.propagate(buffer.concat_buffer, buffer.fc_2_out); fc_2.propagate(buffer.concat_buffer, buffer.fc_2_out);