Joost VandeVondele and nodchip
2931463d3a
Revert earlier TB changes.
...
they were not correct. Unfortunately, also restores the race on RootInTB
2020-09-21 09:45:42 +09:00
Tomasz Sobczyk and nodchip
d4737819cd
Fix castling rights feature encoding.
2020-09-20 20:10:03 +09:00
Joost VandeVondele and nodchip
da28ce3339
Add initialization also to learning patch
...
fixes https://github.com/nodchip/Stockfish/issues/160
2020-09-20 08:16:54 +09:00
Joost VandeVondele and nodchip
61bc8d12d3
Fix some races in learning
...
declare a few variables atomic.
Other races remain...
2020-09-19 10:09:30 +09:00
Joost VandeVondele and nodchip
e8472b5fbe
Fix races in gensfen as detected with thread sanitizer.
...
RootInTB was an incorrectly shared global, probably leading to wrong scoreing
Minor:
setting TB global state from input by all threads (all threads write same values)
setting Limits global state by all threads (idem)
thread counting for finalization
CI can be enabled once races are fixed in the learner, manually goes like:
```
make clean && make -j2 ARCH=x86-64-modern sanitize=thread optimize=no debug=yes build
../tests/instrumented_learn.sh --sanitizer-thread
```
Needs some review.
2020-09-19 10:08:44 +09:00
Tomasz Sobczyk and nodchip
184bde47dc
Add "seed" option to gensfen and learn
2020-09-16 23:09:45 +09:00
Tomasz Sobczyk and nodchip
efca5d561f
More PRNG seeding options
2020-09-16 23:09:45 +09:00
Tomasz Sobczyk and nodchip
bc9be5a71f
Allow setting PRNG seed
2020-09-16 23:09:45 +09:00
nodchip
6ae09ba266
Fixed a bug that the root color is wrong.
2020-09-16 12:10:35 +09:00
Joseph Ellis and nodchip
d160436921
Update description for PruneAtShallowDepthOnPvNode
2020-09-16 10:01:09 +09:00
Tomasz Sobczyk
30a1bc4c64
Change default value of "PruneAtShallowDepthOnPvNode" so that the bench matches master.
2020-09-13 14:19:30 +02:00
Tomasz Sobczyk
89f38c938b
Don't prompt when the training data file doesn't exist when trying to delete it
2020-09-13 13:52:42 +02:00
Tomasz Sobczyk
2e2de7607b
Add extension to the PGO_TRAINING_DATA_FILE so that the generated file name matches the one we try to delete.
2020-09-13 13:47:19 +02:00
Tomasz Sobczyk
e4a4f4001f
parametrize the name of the training data file generated during pgo
2020-09-13 13:44:19 +02:00
Tomasz Sobczyk
9ee8ce67bf
Move removal of generate training data file to profileclean.
2020-09-13 13:42:13 +02:00
Tomasz Sobczyk and GitHub
0f270f7cbf
Merge branch 'master' into no_eval_learn
2020-09-13 13:36:16 +02:00
nodchip and GitHub
cdfa71fa8e
Merge branch 'master' into EvalDir-2020-09-13
2020-09-13 17:32:29 +09:00
Joost VandeVondele and nodchip
3ea2d5ef61
Remove use of non-existent EvalDir option.
...
additionally allow all options to be converted to string.
Without this, restoring of the options (multi_think.cpp:117) can't work.
fixes https://github.com/nodchip/Stockfish/issues/128
Now gensfen/learn pass with debug=yes in CI
2020-09-13 16:38:21 +09:00
nodchip
a94a076e39
Fixed a comment.
2020-09-13 16:35:52 +09:00
nodchip
1c84da9caa
Fixed a bug that an assertion fails in the trainer. if the SkipLoading is false.
...
Fixes #128
2020-09-13 16:32:01 +09:00
Matthies and nodchip
50b4ff8354
Add missing include to make MSVC compile
2020-09-13 09:59:20 +09:00
Tomasz Sobczyk
4b70f4bf23
Add extra ld flags to the proper variable.
2020-09-13 02:07:29 +02:00
Tomasz Sobczyk
72164ba59c
Add missing -fopenmp LDFLAG
2020-09-13 02:06:33 +02:00
Tomasz Sobczyk
fbae6604b1
Remove LEARNCXXFLAGS, LEARNLDFLAGS, BLASDEFINE, BLASCXXFLAGS, BLASLDFLAGS in favor of directly modifying CXXFLAGS and LDFLAGS.
2020-09-13 00:18:01 +02:00
Tomasz Sobczyk
8d1ad6fbf6
Add a makefile option to enable use of BLAS. Default to "no"
2020-09-12 21:16:27 +02:00
Tomasz Sobczyk
1e2fca4040
Move learn target to build target and profile-learn to profile-build.
2020-09-12 16:23:49 +02:00
Tomasz Sobczyk
d33e7a9b07
Remove conditional compilation on EVAL_LEARN
2020-09-12 16:19:24 +02:00
Joost VandeVondele and nodchip
8d499e6efa
Fix flags for dependency generation ( 98f24570ab)
2020-09-12 22:25:36 +09:00
Joost VandeVondele and nodchip
580b09381b
Add a learning command to CI
...
fixes a small issue, with ponder
Probably the learning command can be improved a bit, so that despite the limited data, the code coverage is better.
2020-09-12 22:25:36 +09:00
Tomasz Sobczyk and nodchip
bcfe28b2ae
Fix compilation of sfen_packer.cpp in debug.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
3388c22d71
Fix incorrect use of UCI::Option of type "combo".
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
98f24570ab
Add src to include paths, remove non-standard ".." in includes in learn directory.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
3c87d4fa9b
"Fix" warning when memsetting Position
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
96fa8fa8dc
Add missing files.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
a059fa86c4
Move sfen_packer to learn.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
683c6146ce
Move declarations around and split them.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
c6f5f6a082
Replace "use_raw_nnue_eval" with an uci option "Use NNUE pure"
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
c76bb34a96
Add convert UCI function that allows conversion of files between any of plain, bin, and binpack. Usage: convert infile outfile [append].
2020-09-11 09:36:24 +09:00
nodchip
ac6e6f73f2
Added EnableTranspositionTable UCI option to enable/disable transposition table.
2020-09-11 09:20:48 +09:00
Tomasz Sobczyk and nodchip
59402d4a6d
Include <climits> for CHAR_BIT. Test both formats in instrumented learn.
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
7e6901af27
Remove unused immintring. Include intrin.h only on some platforms, otherwise builtins are used.
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
53ad4d8b56
A speculative build fix for linux.
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
a7ca826593
MIT license/copyright notice in the library file.
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
585a5351bf
Fix warnings.
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
6b76ebc2ca
Support for binpack format in sfenreader in learner. Automatically detect file extension and choose the correct reader (bin or binpack)
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
020e66d2e6
Add "sfen_format" option in gensfen. Valid values are "bin" and "binpack". It determines the output format of the sfens. Binpack is a highly compressed formats for consecutive sfens. Extension is now determined by the used format, output_file_name should contain just the stem.
2020-09-10 21:19:37 +09:00
nodchip
94f3cae760
Changed a sentence.
2020-09-10 08:23:21 +09:00
nodchip
e63b6088ba
Changed a option name more descriptive, "Training" -> "PruneAtShallowDepthOnPvNode". The default value was changed but the default behavior is not changed.
...
Changed to set a global option prune_at_shallow_depth_on_pv_node on a callback function.
2020-09-10 08:19:54 +09:00
Joost VandeVondele and nodchip
e0a9860708
Upgrade CI distro, remove special cases, fix one more warning
2020-09-10 08:15:15 +09:00
nodchip
9dcadfa642
Removed compile warnings.
2020-09-09 23:02:39 +09:00
