Joost VandeVondele and nodchip
2931463d3a
Revert earlier TB changes.
...
they were not correct. Unfortunately, also restores the race on RootInTB
2020-09-21 09:45:42 +09:00
Joost VandeVondele and nodchip
da28ce3339
Add initialization also to learning patch
...
fixes https://github.com/nodchip/Stockfish/issues/160
2020-09-20 08:16:54 +09:00
Joost VandeVondele and nodchip
61bc8d12d3
Fix some races in learning
...
declare a few variables atomic.
Other races remain...
2020-09-19 10:09:30 +09:00
Joost VandeVondele and nodchip
e8472b5fbe
Fix races in gensfen as detected with thread sanitizer.
...
RootInTB was an incorrectly shared global, probably leading to wrong scoreing
Minor:
setting TB global state from input by all threads (all threads write same values)
setting Limits global state by all threads (idem)
thread counting for finalization
CI can be enabled once races are fixed in the learner, manually goes like:
```
make clean && make -j2 ARCH=x86-64-modern sanitize=thread optimize=no debug=yes build
../tests/instrumented_learn.sh --sanitizer-thread
```
Needs some review.
2020-09-19 10:08:44 +09:00
Tomasz Sobczyk and nodchip
184bde47dc
Add "seed" option to gensfen and learn
2020-09-16 23:09:45 +09:00
nodchip
6ae09ba266
Fixed a bug that the root color is wrong.
2020-09-16 12:10:35 +09:00
Tomasz Sobczyk and GitHub
0f270f7cbf
Merge branch 'master' into no_eval_learn
2020-09-13 13:36:16 +02:00
nodchip
a94a076e39
Fixed a comment.
2020-09-13 16:35:52 +09:00
nodchip
1c84da9caa
Fixed a bug that an assertion fails in the trainer. if the SkipLoading is false.
...
Fixes #128
2020-09-13 16:32:01 +09:00
Tomasz Sobczyk
d33e7a9b07
Remove conditional compilation on EVAL_LEARN
2020-09-12 16:19:24 +02:00
Joost VandeVondele and nodchip
580b09381b
Add a learning command to CI
...
fixes a small issue, with ponder
Probably the learning command can be improved a bit, so that despite the limited data, the code coverage is better.
2020-09-12 22:25:36 +09:00
Tomasz Sobczyk and nodchip
bcfe28b2ae
Fix compilation of sfen_packer.cpp in debug.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
98f24570ab
Add src to include paths, remove non-standard ".." in includes in learn directory.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
96fa8fa8dc
Add missing files.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
683c6146ce
Move declarations around and split them.
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
c6f5f6a082
Replace "use_raw_nnue_eval" with an uci option "Use NNUE pure"
2020-09-11 21:53:17 +09:00
Tomasz Sobczyk and nodchip
c76bb34a96
Add convert UCI function that allows conversion of files between any of plain, bin, and binpack. Usage: convert infile outfile [append].
2020-09-11 09:36:24 +09:00
Tomasz Sobczyk and nodchip
6b76ebc2ca
Support for binpack format in sfenreader in learner. Automatically detect file extension and choose the correct reader (bin or binpack)
2020-09-10 21:19:37 +09:00
Tomasz Sobczyk and nodchip
020e66d2e6
Add "sfen_format" option in gensfen. Valid values are "bin" and "binpack". It determines the output format of the sfens. Binpack is a highly compressed formats for consecutive sfens. Extension is now determined by the used format, output_file_name should contain just the stem.
2020-09-10 21:19:37 +09:00
nodchip
9dcadfa642
Removed compile warnings.
2020-09-09 23:02:39 +09:00
nodchip
7bd4688747
Remove compile warnings.
2020-09-09 23:02:39 +09:00
Joost VandeVondele and nodchip
17d42e023e
add more CI, instrumented runs
2020-09-09 19:40:43 +09:00
nodchip
2583f68972
Removed macros for KPP evaluate functions.
2020-09-09 10:26:42 +09:00
nodchip
8d763fb503
Removed LEARN_GENSFEN_USE_DRAW_RESULT macro.
2020-09-09 10:26:42 +09:00
nodchip
eafa569365
Removed macros for KPP factorization.
2020-09-09 10:26:42 +09:00
nodchip
5e25702672
Removed USE_TRIANGLE_WEIGHT_ARRAY macro.
2020-09-09 10:26:42 +09:00
nodchip
f52165e1d3
Removed RESET_TO_ZERO_VECTOR macro.
2020-09-09 10:26:42 +09:00
nodchip
dbad9d96e0
Removed LOSS_FUNCTION_IS_ELMO_METHOD macro.
2020-09-09 10:26:42 +09:00
nodchip
ef1601218d
Removed LOSS_FUNCTION_IS_CROSS_ENTOROPY_FOR_VALUE macro.
2020-09-09 10:26:42 +09:00
nodchip
f52fbf8006
Removed LOSS_FUNCTION_IS_CROSS_ENTOROPY macro.
2020-09-09 10:26:42 +09:00
nodchip
d37eb63581
Removed LOSS_FUNCTION_IS_WINNING_PERCENTAGE macro.
2020-09-09 10:26:42 +09:00
nodchip
f3a158725d
Removed SGD_UPDATE macro.
2020-09-09 10:26:42 +09:00
nodchip
0271d70775
Removed ADA_GRAD_UPDATE macro.
2020-09-09 10:26:42 +09:00
nodchip
05d26499b4
Removed LEARN_ELMO_METHOD macro.
2020-09-09 10:26:42 +09:00
nodchip
82dc68ba9f
Removed #if for USE_GLOBAL_OPTIONS.
2020-09-09 10:26:42 +09:00
nodchip
aa2452caf3
Removed #if for USE_EVAL_HASH.
2020-09-09 10:26:42 +09:00
nodchip
ec96409176
Replaced DNDEBUG macro to _DEBUG macro.
2020-09-09 10:26:42 +09:00
nodchip
04a9a951b8
Removed "#if 0" and "#if 1".
2020-09-09 10:26:42 +09:00
nodchip
21cfead52c
Removed unused OMP_ macro.
2020-09-09 10:26:42 +09:00
nodchip
e6a6ba5221
Removed USE_BOOK macro.
2020-09-09 10:26:42 +09:00
nodchip
a6013557f2
Removed EVAL_NNUE macro.
2020-09-09 10:26:42 +09:00
Tomasz Sobczyk and nodchip
41b7674aee
Improve comments, break long lines.
2020-09-08 20:07:30 +09:00
Tomasz Sobczyk and nodchip
1482e5215a
A second batch of code reorganization.
2020-09-08 20:07:30 +09:00
Tomasz Sobczyk and nodchip
832c414b0d
First batch of reorganization.
2020-09-08 20:07:30 +09:00
noobpwnftw and nodchip
58863c3243
Update gensfen.cpp
2020-09-08 13:22:41 +09:00
nodchip
4cc98d80f8
Replaced the utility function to create a directory to std::filesystem.
2020-09-07 18:56:41 +09:00
Joost VandeVondele and nodchip
edbbc1a4df
Remove some warnings
2020-09-07 09:20:47 +09:00
Joost VandeVondele and nodchip
3bf418e63f
Fix some uninitialized variables with gensfen
...
fixes valgrind errors as seen with:
```
setoption name Use NNUE value true
isready
gensfen depth 6 loop 10 use_draw_in_training_data_generation 1 eval_limit 32000 output_file_name training_data/training_data.bin use_raw_nnue_eval 0
quit
```
the latter script now runs without valgrind errors on linux
2020-09-07 09:01:17 +09:00
Tomasz Sobczyk and nodchip
e9e6e47a93
Fix write_out_draw_game_in_training_data_generation flag not being respected.
2020-09-06 22:00:51 +09:00
Tomasz Sobczyk and nodchip
0612adec41
Fix incorrect early exit in evaluate_leaf.
2020-09-05 08:43:34 +09:00
