Commit Graph
150 Commits
Author SHA1 Message Date
Tomasz Sobczykandnodchip 146a6b056e PascalCase -> snake_case for consistency with the rest of the codebase. 2020-10-19 18:37:23 +09:00
Tomasz Sobczykandnodchip 69ea3d30b2 Move the extra new line to after check health. 2020-10-19 08:29:51 +09:00
Tomasz Sobczykandnodchip c93f8732bf Force Use NNUE to pure when learning. 2020-10-17 08:44:38 +09:00
Tomasz Sobczykandnodchip 5db46d0c82 Verify whether there is a network being used during training. 2020-10-17 08:44:38 +09:00
Tomasz Sobczykandnodchip e503cc4ea8 Add one more empty line between progress reports. 2020-10-17 00:13:50 +09:00
Tomasz Sobczykandnodchip 5856237e3f Rename hirate to startpos 2020-10-16 09:07:02 +09:00
Tomasz Sobczykandnodchip 904adb9a32 Indentation consistency in learn folder 2020-10-15 22:11:31 +09:00
Tomasz Sobczykandnodchip 880d23af1c Move sfen input/output streams to sfen_stream.h 2020-10-15 20:37:03 +09:00
Tomasz Sobczykandnodchip 14f83ad7b9 Move public search/qsearch interface from namespace Learner to namespace Search 2020-10-15 20:37:03 +09:00
Tomasz Sobczykandnodchip 0494adeb2c Move nnue evaluation stuff from evaluate.h to nnue/evaluate_nnue.h 2020-10-15 20:37:03 +09:00
Tomasz Sobczykandnodchip 4a2bf16b30 Add option "auto_lr_drop" that specifies the amount of positions from previous lr drop after which to reduce lr by newbob_decay. 2020-10-12 23:56:26 +09:00
Tomasz Sobczykandnodchip 7d62b3f799 Store additional bits for fullmove clock and 50 more rule halfmove clock at the end of the bit stream. This change keeps backwards compatibility. 2020-10-11 20:59:27 +09:00
Tomasz Sobczykandnodchip ef57ac78a3 Print gensfen speed when outputting status. 2020-10-09 08:14:48 +09:00
Joost VandeVondeleandnodchip adddf339bb Output sfens/second in the trainer, to track performance more easily 2020-10-08 08:29:42 +09:00
Tomasz Sobczykandnodchip 3f55b3af42 Change some gensfen parameter defaults. 2020-10-07 23:09:33 +09:00
Tomasz Sobczykandnodchip 8830209125 Change some learn parameter defaults. 2020-10-07 23:09:33 +09:00
Tomasz Sobczykandnodchip 2e57f3fa22 Switch to set recommended learn UCI options 2020-10-07 23:09:33 +09:00
Tomasz Sobczykandnodchip d1c44dca04 Switch to set recommended gensfen UCI options 2020-10-07 23:09:33 +09:00
noobpwnftwandnodchip 6f7a228707 Minor cleanups
Remove unused code and magic numbers
2020-10-01 16:52:20 +09:00
noobpwnftwandnodchip b44d539c94 Fix a bug that LR is not correctly scaled when initial LR is not 1.0 2020-09-29 16:18:42 +09:00
noobpwnftwandnodchip 5e8a49f7f2 Restore lambda and gradient function post-merge and minor fixes.
bench: 3788313
2020-09-26 12:55:02 +09:00
Tomasz Sobczyk c99541828f Remove the re-search on depth 0. It is correctly handled by search now. 2020-09-25 16:06:33 +02:00
Tomasz Sobczyk b6e7733b4c In gensfen call search before get_current_game_result so that rootMoves is initialized by Learner::init_for_search. Don't call Tablebases::rank_root_moves in get_current_game_result because it's called in Learner::init_for_search. This fixes accessing uninitialized variables related to tablebases. 2020-09-25 15:04:21 +02:00
Tomasz Sobczyk 9f3de8b40e Revert some unwanted changes from merge conflict resolution. 2020-09-24 21:10:10 +02:00
noobpwnftw 9827411b7c Merge remote-tracking branch 'remotes/nodchip/master' into trainer 2020-09-24 21:45:28 +08:00
noobpwnftw 5be8b573be Merge remote-tracking branch 'remotes/origin/master' into trainer 2020-09-23 19:02:27 +08:00
noobpwnftw 411adab149 Merge remote-tracking branch 'remotes/nodchip/master' into trainer 2020-09-23 18:29:30 +08:00
Joost VandeVondeleandnodchip 2931463d3a Revert earlier TB changes.
they were not correct. Unfortunately, also restores the race on RootInTB
2020-09-21 09:45:42 +09:00
Joost VandeVondeleandnodchip da28ce3339 Add initialization also to learning patch
fixes https://github.com/nodchip/Stockfish/issues/160
2020-09-20 08:16:54 +09:00
Joost VandeVondeleandnodchip 61bc8d12d3 Fix some races in learning
declare a few variables atomic.

Other races remain...
2020-09-19 10:09:30 +09:00
Joost VandeVondeleandnodchip e8472b5fbe Fix races in gensfen as detected with thread sanitizer.
RootInTB was an incorrectly shared global, probably leading to wrong scoreing

Minor:
 setting TB global state from input by all threads (all threads write same values)
 setting Limits global state by all threads (idem)
 thread counting for finalization

CI can be enabled once races are fixed in the learner, manually goes like:
```
make clean && make -j2 ARCH=x86-64-modern sanitize=thread    optimize=no debug=yes build
../tests/instrumented_learn.sh --sanitizer-thread
```

Needs some review.
2020-09-19 10:08:44 +09:00
noobpwnftw a47a3bfc7c Merge remote-tracking branch 'remotes/nodchip/master' into trainer 2020-09-19 02:14:17 +08:00
Tomasz Sobczykandnodchip 184bde47dc Add "seed" option to gensfen and learn 2020-09-16 23:09:45 +09:00
nodchip 6ae09ba266 Fixed a bug that the root color is wrong. 2020-09-16 12:10:35 +09:00
Tomasz SobczykandGitHub 0f270f7cbf Merge branch 'master' into no_eval_learn 2020-09-13 13:36:16 +02:00
nodchip a94a076e39 Fixed a comment. 2020-09-13 16:35:52 +09:00
nodchip 1c84da9caa Fixed a bug that an assertion fails in the trainer. if the SkipLoading is false.
Fixes #128
2020-09-13 16:32:01 +09:00
Tomasz Sobczyk d33e7a9b07 Remove conditional compilation on EVAL_LEARN 2020-09-12 16:19:24 +02:00
Joost VandeVondeleandnodchip 580b09381b Add a learning command to CI
fixes a small issue, with ponder

Probably the learning command can be improved a bit, so that despite the limited data, the code coverage is better.
2020-09-12 22:25:36 +09:00
Tomasz Sobczykandnodchip bcfe28b2ae Fix compilation of sfen_packer.cpp in debug. 2020-09-11 21:53:17 +09:00
Tomasz Sobczykandnodchip 98f24570ab Add src to include paths, remove non-standard ".." in includes in learn directory. 2020-09-11 21:53:17 +09:00
Tomasz Sobczykandnodchip 96fa8fa8dc Add missing files. 2020-09-11 21:53:17 +09:00
Tomasz Sobczykandnodchip 683c6146ce Move declarations around and split them. 2020-09-11 21:53:17 +09:00
Tomasz Sobczykandnodchip c6f5f6a082 Replace "use_raw_nnue_eval" with an uci option "Use NNUE pure" 2020-09-11 21:53:17 +09:00
Tomasz Sobczykandnodchip c76bb34a96 Add convert UCI function that allows conversion of files between any of plain, bin, and binpack. Usage: convert infile outfile [append]. 2020-09-11 09:36:24 +09:00
Tomasz Sobczykandnodchip 6b76ebc2ca Support for binpack format in sfenreader in learner. Automatically detect file extension and choose the correct reader (bin or binpack) 2020-09-10 21:19:37 +09:00
Tomasz Sobczykandnodchip 020e66d2e6 Add "sfen_format" option in gensfen. Valid values are "bin" and "binpack". It determines the output format of the sfens. Binpack is a highly compressed formats for consecutive sfens. Extension is now determined by the used format, output_file_name should contain just the stem. 2020-09-10 21:19:37 +09:00
nodchip 9dcadfa642 Removed compile warnings. 2020-09-09 23:02:39 +09:00
nodchip 7bd4688747 Remove compile warnings. 2020-09-09 23:02:39 +09:00
noobpwnftw b3a0ded37a Merge remote-tracking branch 'remotes/nodchip/master' into trainer 2020-09-09 21:42:45 +08:00