mirror of
https://github.com/official-stockfish/Stockfish.git
synced 2026-07-23 05:07:14 +00:00
Joost VandeVondeleandJoona Kiiski
3cb0200459
the nodes, tbHits, rootDepth and lastInfoTime variables are read by multiple threads, but not declared atomic, leading to data races as found by -fsanitize=thread. This patch fixes this issue. It is based on top of the CI-threading branch (PR #1129), and should fix the corresponding CI error messages. The patch passed an STC check for no regression: http://tests.stockfishchess.org/tests/view/5925d5590ebc59035df34b9f LLR: 2.96 (-2.94,2.94) [-3.00,1.00] Total: 169597 W: 29938 L: 30066 D: 109593 Whereas rootDepth and lastInfoTime are not performance critical, nodes and tbHits are. Indeed, an earlier version using relaxed atomic updates on the latter two variables failed STC testing (http://tests.stockfishchess.org/tests/view/592001700ebc59035df34924), which can be shown to be due to x86-32 (http://tests.stockfishchess.org/tests/view/592330ac0ebc59035df34a89). Indeed, the latter have no instruction to atomically update a 64bit variable. The proposed solution thus uses a variable in Position that is accessed only by one thread, which is copied every few thousand nodes to the shared variable in Thread. No functional change. Closes #1130 Closes #1129
118 lines
2.3 KiB
Bash
Executable File
118 lines
2.3 KiB
Bash
Executable File
#!/bin/bash
|
|
# check for errors under valgrind or sanitizers.
|
|
|
|
error()
|
|
{
|
|
echo "instrumented testing failed on line $1"
|
|
exit 1
|
|
}
|
|
trap 'error ${LINENO}' ERR
|
|
|
|
# define suitable post and prefixes for testing options
|
|
case $1 in
|
|
--valgrind)
|
|
echo "valgrind testing started"
|
|
prefix=''
|
|
exeprefix='valgrind --error-exitcode=42'
|
|
postfix='1>/dev/null'
|
|
threads="1"
|
|
;;
|
|
--sanitizer-undefined)
|
|
echo "sanitizer testing started"
|
|
prefix='!'
|
|
exeprefix=''
|
|
postfix='2>&1 | grep "runtime error:"'
|
|
threads="1"
|
|
;;
|
|
--sanitizer-thread)
|
|
echo "sanitizer testing started"
|
|
prefix='!'
|
|
exeprefix=''
|
|
postfix='2>&1 | grep "WARNING: ThreadSanitizer:"'
|
|
threads="2"
|
|
|
|
cat << EOF > tsan.supp
|
|
race:TTEntry::move
|
|
race:TTEntry::depth
|
|
race:TTEntry::bound
|
|
race:TTEntry::save
|
|
race:TTEntry::value
|
|
race:TTEntry::eval
|
|
|
|
race:TranspositionTable::probe
|
|
race:TranspositionTable::generation
|
|
race:TranspositionTable::hashfull
|
|
|
|
EOF
|
|
|
|
export TSAN_OPTIONS="suppressions=./tsan.supp"
|
|
|
|
;;
|
|
*)
|
|
echo "unknown testing started"
|
|
prefix=''
|
|
exeprefix=''
|
|
postfix=''
|
|
threads="1"
|
|
;;
|
|
esac
|
|
|
|
# simple command line testing
|
|
for args in "eval" \
|
|
"go nodes 1000" \
|
|
"go depth 10" \
|
|
"go movetime 1000" \
|
|
"go wtime 8000 btime 8000 winc 500 binc 500" \
|
|
"bench 128 $threads 10 default depth"
|
|
do
|
|
|
|
echo "$prefix $exeprefix ./stockfish $args $postfix"
|
|
eval "$prefix $exeprefix ./stockfish $args $postfix"
|
|
|
|
done
|
|
|
|
# more general testing, following an uci protocol exchange
|
|
cat << EOF > game.exp
|
|
set timeout 10
|
|
spawn $exeprefix ./stockfish
|
|
|
|
send "uci\n"
|
|
expect "uciok"
|
|
|
|
send "setoption name Threads value $threads\n"
|
|
|
|
send "ucinewgame\n"
|
|
send "position startpos\n"
|
|
send "go nodes 1000\n"
|
|
expect "bestmove"
|
|
|
|
send "position startpos moves e2e4 e7e6\n"
|
|
send "go nodes 1000\n"
|
|
expect "bestmove"
|
|
|
|
send "position fen 5rk1/1K4p1/8/8/3B4/8/8/8 b - - 0 1\n"
|
|
send "go depth 30\n"
|
|
expect "bestmove"
|
|
|
|
send "quit\n"
|
|
expect eof
|
|
|
|
# return error code of the spawned program, useful for valgrind
|
|
lassign [wait] pid spawnid os_error_flag value
|
|
exit \$value
|
|
EOF
|
|
|
|
for exps in game.exp
|
|
do
|
|
|
|
echo "$prefix expect $exps $postfix"
|
|
eval "$prefix expect $exps $postfix"
|
|
|
|
rm $exps
|
|
|
|
done
|
|
|
|
rm -f tsan.supp
|
|
|
|
echo "instrumented testing OK"
|