mirror of
https://github.com/official-stockfish/Stockfish.git
synced 2026-07-22 12:47:08 +00:00
Miloslav MacůrekandJoost VandeVondele
9700f6f206
`Skill::pick_best()` assumes the root moves are sorted by score in descending order:
```cpp
Value topScore = rootMoves[0].score;
int delta = std::min(topScore - rootMoves[multiPV - 1].score, int(PawnValue));
```
That does not have to be so with Syzygy tablebases at the root, where the moves are ordered by `tbRank` instead. `rootMoves[0]` is then not the highest score and `delta` can go negative. Since `delta * (rng.rand<unsigned>() % int(weakness))` is evaluated as unsigned, a negative `delta` wraps to a large value and the `int(...)` cast overflows, so the `score + push >= maxScore` check never passes and `best` stays `Move::none()`. The caller
```cpp
std::swap(rootMoves[0],
*std::find(rootMoves.begin(), rootMoves.end(),
skill.best ? skill.best : skill.pick_best(rootMoves, multiPV)));
```
then dereferences `end()`. The result is a crash, or sometimes `bestmove (none)` / an illegal move, in tablebase endgames when `UCI_LimitStrength` is set (or `Skill Level` is below 20).
The fix computes the score range over the candidate moves directly, so `delta` stays non-negative and a valid move is always returned.
**To reproduce**:
```
setoption name UCI_LimitStrength value true
setoption name UCI_Elo value 2900
setoption name SyzygyPath value <syzygy tablebases path>
position fen 8/8/8/4k3/8/8/3BKN2/8 b - - 0 1
go wtime 250 btime 250 winc 100 binc 100
```
You need to call the go command a couple of times before crash, after which is ends with
```
bestmove a1e5 ponder (none)
```
and on the next `go wtime 250 btime 250 winc 100 binc 100` it crashes printing:
```
info string Available processors: 0-31
info string Using 1 thread
info string NNUE evaluation using nn-af1339a6dea3.nnue (106MiB, (83248, 1024, 31, 32, 1))
info string Network replica 1: Shared memory.
```
Bench is unchanged, since this code only runs under `UCI_LimitStrength` / `Skill Level`.
closes https://github.com/official-stockfish/Stockfish/pull/6957
No functional change
291 lines
6.6 KiB
Plaintext
291 lines
6.6 KiB
Plaintext
# Founders of the Stockfish project and Fishtest infrastructure
|
|
Tord Romstad (romstad)
|
|
Marco Costalba (mcostalba)
|
|
Joona Kiiski (zamar)
|
|
Gary Linscott (glinscott)
|
|
|
|
# Authors and inventors of NNUE, training, and NNUE port
|
|
Yu Nasu (ynasu87)
|
|
Motohiro Isozaki (yaneurao)
|
|
Hisayori Noda (nodchip)
|
|
|
|
# All other authors of Stockfish code (in alphabetical order)
|
|
87flowers
|
|
Aditya (absimaldata)
|
|
Adrian Ladoni (AdrianGHUB15)
|
|
Adrian Petrescu (apetresc)
|
|
Ahmed Kerimov (wcdbmv)
|
|
Ajith Chandy Jose (ajithcj)
|
|
AK-Khan02
|
|
Alain Savard (Rocky640)
|
|
Alayan Feh (Alayan-stk-2)
|
|
Alexander Kure
|
|
Alexander Pagel (Lolligerhans)
|
|
Alfredo Menezes (lonfom169)
|
|
Ali AlZhrani (Cooffe)
|
|
AliceRoselia
|
|
Andreas Jan van der Meulen (Andyson007)
|
|
Andreas Matthies (Matthies)
|
|
Andrei Vetrov (proukornew)
|
|
Andrew Grant (AndyGrant)
|
|
Andrey Neporada (nepal)
|
|
Andy Duplain
|
|
Antoine Champion (antoinechampion)
|
|
Aram Tumanian (atumanian)
|
|
Arjun Temurnikar
|
|
Aron Petkovski (fury)
|
|
Arseniy Surkov (codedeliveryservice)
|
|
Artem Solopiy (EntityFX)
|
|
Auguste Pop
|
|
Balazs Szilagyi
|
|
Balint Pfliegel
|
|
Baptiste Rech (breatn)
|
|
Ben Chaney (Chaneybenjamini)
|
|
Ben Koshy (BKSpurgeon)
|
|
Bill Henry (VoyagerOne)
|
|
Bojun Guo (noobpwnftw, Nooby)
|
|
borg323
|
|
Boštjan Mejak (PedanticHacker)
|
|
braich
|
|
Brian Sheppard (SapphireBrand, briansheppard-toast)
|
|
Bruno de Melo Costa (BM123499)
|
|
Bruno Pellanda (pellanda)
|
|
Bryan Cross (crossbr)
|
|
candirufish
|
|
Carlos Esparza Sánchez (ces42)
|
|
Chess13234
|
|
Chris Bao (sscg13)
|
|
Chris Cain (ceebo)
|
|
Ciekce
|
|
clefrks
|
|
Clemens L. (rn5f107s2)
|
|
Cody Ho (aesrentai)
|
|
CSTENTOR
|
|
Dale Weiler (graphitemaster)
|
|
Dalton Hanaway (dhanaway)
|
|
Dan Schmidt (dfannius)
|
|
Daniel Axtens (daxtens)
|
|
Daniel Dugovic (ddugovic)
|
|
Daniel Monroe (daniel-monroe)
|
|
Daniel Samek (DanSamek)
|
|
Dariusz Orzechowski (dorzechowski)
|
|
David (dav1312)
|
|
David Zar
|
|
Daylen Yang (daylen)
|
|
Deshawn Mohan-Smith (GoldenRare)
|
|
Dieter Dobbelaere (ddobbelaere)
|
|
DiscanX
|
|
Dominik Schlösser (domschl)
|
|
double-beep
|
|
Douglas Matos Gomes (dsmsgms)
|
|
Dubslow
|
|
Eduardo Cáceres (eduherminio)
|
|
Eelco de Groot (KingDefender)
|
|
Ehsan Rashid (erashid)
|
|
Elvin Liu (solarlight2)
|
|
erbsenzaehler
|
|
Ernesto Gatti
|
|
evqsx
|
|
Fabian Beuke (madnight)
|
|
Fabian Fichter (ianfab)
|
|
Fanael Linithien (Fanael)
|
|
fanon
|
|
Fauzi Akram Dabat (fauzi2)
|
|
Felix Wittmann
|
|
Gabriele Lombardo (gabe)
|
|
Gahtan Nahdi
|
|
gamander
|
|
Gary Heckman (gheckman)
|
|
George Sobala (gsobala)
|
|
gguliash
|
|
Giacomo Lorenzetti (G-Lorenz)
|
|
Gian-Carlo Pascutto (gcp)
|
|
Goh CJ (cj5716)
|
|
Gontran Lemaire (gonlem)
|
|
Goodkov Vasiliy Aleksandrovich (goodkov)
|
|
Gregor Cramer
|
|
GuardianRM
|
|
Günther Demetz (pb00067, pb00068)
|
|
Guy Vreuls (gvreuls)
|
|
Henri Wiechers
|
|
Hiraoka Takuya (HiraokaTakuya)
|
|
homoSapiensSapiens
|
|
Hongzhi Cheng
|
|
Ivan Ivec (IIvec)
|
|
Jacques B. (Timshel)
|
|
Jake Senne (w1wwwwww)
|
|
Jakub Ciolek (jake-ciolek)
|
|
Jan Ondruš (hxim)
|
|
Jared Kish (Kurtbusch, kurt22i)
|
|
Jarrod Torriero (DU-jdto)
|
|
Jasper Shovelton (Beanie496)
|
|
Jean Gauthier (OuaisBla)
|
|
Jean-Francois Romang (jromang)
|
|
Jekaa
|
|
Jerry Donald Watson (jerrydonaldwatson)
|
|
jjoshua2
|
|
Jonathan Buladas Dumale (SFisGOD)
|
|
Jonathan Calovski (Mysseno)
|
|
Jonathan McDermid (jonathanmcdermid)
|
|
Joost VandeVondele (vondele)
|
|
Jörg Oster (joergoster)
|
|
Joseph Ellis (jhellis3)
|
|
Joseph R. Prostko
|
|
Jost Triller (tsoj)
|
|
Julian Willemer (NightlyKing)
|
|
jundery
|
|
Justin Blanchard (UncombedCoconut)
|
|
Kazuki Yamashita (KazApps)
|
|
Kelly Wilson
|
|
Ken Takusagawa
|
|
Kenneth Lee (kennethlee33)
|
|
kevlu8
|
|
Kian E (KJE-98)
|
|
Kieren Pearson (KierenP)
|
|
kinderchocolate
|
|
Kiran Panditrao (Krgp)
|
|
Kirill Zaripov (kokodio)
|
|
Kojirion
|
|
Krisztián Peőcz
|
|
Krystian Kuzniarek (kuzkry)
|
|
Leonardo Ljubičić (ICCF World Champion)
|
|
Leonid Pechenik (lp--)
|
|
Li Ying (yl25946)
|
|
Liam Keegan (lkeegan)
|
|
Linmiao Xu (linrock)
|
|
Linus Arver (listx)
|
|
loco-loco
|
|
Lub van den Berg (ElbertoOne)
|
|
Luca Brivio (lucabrivio)
|
|
Lucas Braesch (lucasart)
|
|
Lyudmil Antonov (lantonov)
|
|
Maciej Żenczykowski (zenczykowski)
|
|
Malcolm Campbell (xoto10)
|
|
Mark Marosi (Mapika)
|
|
Mark Tenzer (31m059)
|
|
marotear
|
|
Mathias Parnaudeau (mparnaudeau)
|
|
Matt Ginsberg (mattginsberg)
|
|
Matthew Lai (matthewlai)
|
|
Matthew Sullivan (Matt14916)
|
|
Max A. (Disservin)
|
|
Maxim Masiutin (maximmasiutin)
|
|
Maxim Molchanov (Maxim)
|
|
Michael An (man)
|
|
Michael Byrne (MichaelB7)
|
|
Michael Chaly (Vizvezdenec)
|
|
Michael Stembera (mstembera)
|
|
Michael Whiteley (protonspring)
|
|
Michel Van den Bergh (vdbergh)
|
|
Miguel Lahoz (miguel-l)
|
|
Mikael Bäckman (mbootsector)
|
|
Mike Babigian (Farseer)
|
|
Miloslav Macůrek (maelic13)
|
|
Mira
|
|
Miroslav Fontán (Hexik)
|
|
Moez Jellouli (MJZ1977)
|
|
Mohammed Li (tthsqe12)
|
|
Mukhammedali Beriktassuly (Berektassuly)
|
|
Muzhen J (XInTheDark)
|
|
Mafanwei
|
|
Nathan Rugg (nmrugg)
|
|
Nguyen Pham (nguyenpham)
|
|
Nick Pelling (nickpelling)
|
|
Nicklas Persson (NicklasPersson)
|
|
Nicolas Duhamel (nikloskoda)
|
|
Niklas Fiekas (niklasf)
|
|
Nikolay Kostov (NikolayIT)
|
|
Norman Schmidt (FireFather)
|
|
notruck
|
|
Nour Berakdar (Nonlinear)
|
|
Ofek Shochat (OfekShochat, ghostway)
|
|
Ömer Faruk Tutkun (OmerFarukTutkun)
|
|
Ondřej Mišina (AndrovT)
|
|
Ondrej Mosnáček (WOnder93)
|
|
Onur Zungur (zungur)
|
|
Oskar Werkelin Ahlin
|
|
Pablo Vazquez
|
|
Panthee
|
|
Pascal Romaret
|
|
Pasquale Pigazzini (ppigazzini)
|
|
Patrick Jansen (mibere)
|
|
Patrick Leonhardt (Yoshie2000)
|
|
Peter Schneider (pschneider1968)
|
|
Peter Zsifkovits (CoffeeOne)
|
|
Pieter te Brake (pieterteb)
|
|
PikaCat
|
|
Praveen Kumar Tummala (praveentml)
|
|
Prokop Randáček (ProkopRandacek)
|
|
Rahul Dsilva (silversolver1)
|
|
Ralph Stößer (Ralph Stoesser)
|
|
Raminder Singh
|
|
renouve
|
|
Reuven Peleg (R-Peleg)
|
|
Richard Lloyd (Richard-Lloyd)
|
|
Robert Nürnberg (robertnurnberg)
|
|
Rodrigo Exterckötter Tjäder
|
|
Rodrigo Roim (roim)
|
|
Ron Britvich (Britvich)
|
|
Ronald de Man (syzygy1, syzygy)
|
|
rqs
|
|
Rui Coelho (ruicoelhopedro)
|
|
rustam-cpp
|
|
Ryan Hirsch
|
|
Ryan Lefkowitz (rlefko)
|
|
Ryan Schmitt
|
|
Ryan Takker
|
|
Sami Kiminki (skiminki)
|
|
Sebastian Buchwald (UniQP)
|
|
Sergei Antonov (saproj)
|
|
Sergei Ivanov (svivanov72)
|
|
Sergio Vieri (sergiovieri)
|
|
sf-x
|
|
Shahin M. Shahin (peregrine)
|
|
Shane Booth (shane31)
|
|
Shawn Varghese (xXH4CKST3RXx)
|
|
Shawn Xu (xu-shawn)
|
|
Siad Daboul (Topologist)
|
|
Stefan Geschwentner (locutus2)
|
|
Stefano Cardanobile (Stefano80)
|
|
Stefano Di Martino (StefanoD)
|
|
Steinar Gunderson (sesse)
|
|
Stéphane Nicolet (snicolet)
|
|
Stephen Touset (stouset)
|
|
Stockfisher69
|
|
Styx (styxdoto)
|
|
Syine Mineta (MinetaS)
|
|
Taras Vuk (TarasVuk)
|
|
Thanar2
|
|
thaspel
|
|
theo77186
|
|
TierynnB
|
|
Timothy Herchen (anematode)
|
|
Ting-Hsuan Huang (fffelix-huang)
|
|
tobi437a
|
|
Tobias Steinmann
|
|
Tom Truscott
|
|
Tom Vijlbrief (tomtor)
|
|
Tomasz Sobczyk (Sopel97)
|
|
Tony Wang (TonyCongqianWang)
|
|
Torsten Franz (torfranz, tfranzer)
|
|
Torsten Hellwig (Torom)
|
|
Tracey Emery (basepr1me)
|
|
tttak
|
|
Unai Corzo (unaiic)
|
|
Uri Blass (uriblass)
|
|
Vince Negri (cuddlestmonkey)
|
|
Viren
|
|
Wencey Wang
|
|
Will Miles (willm)
|
|
windfishballad
|
|
xefoci7612
|
|
Xiang Wang (KatyushaScarlet)
|
|
Yen-Chao Shen (lemteay)
|
|
ZlomenyMesic
|
|
zz4032
|
|
|
|
# Additionally, we acknowledge the authors and maintainers of fishtest,
|
|
# an amazing and essential framework for Stockfish development!
|
|
#
|
|
# https://github.com/official-stockfish/fishtest/blob/master/AUTHORS
|