jirayu_sri/YouTube.js
1
0
Fork 0
mirror of https://github.com/LuanRT/YouTube.js.git synced 2026-06-13 01:22:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: Replace uses of ObservableArray#get with Array#find (#1013)

Browse Source
This commit is contained in:
absidue
2025-09-11 20:45:16 +02:00
committed by GitHub
parent 8be677adec
commit 95976de115
11 changed files with 28 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/mixins/Feed.ts
View File

@@ -160,7 +160,7 @@ export default class Feed<T extends IParsedResponse = IParsedResponse> {
* Finds shelf by title.
*/
getShelf(title: string) {
return this.shelves.get({ title });
return this.shelves.find((shelf) => shelf.title.toString() === title);
}
/**

4
src/core/mixins/MediaInfo.ts
View File

@@ -188,8 +188,8 @@ export default class MediaInfo {
if (!next_response.engagement_panels)
throw new InnertubeError('Engagement panels not found. Video likely has no transcript.');
const transcript_panel = next_response.engagement_panels.get({
panel_identifier: 'engagement-panel-searchable-transcript'
const transcript_panel = next_response.engagement_panels.find((panel) => {
return panel.panel_identifier === 'engagement-panel-searchable-transcript';
});
if (!transcript_panel)

6
src/parser/youtube/Channel.ts
View File

@@ -62,7 +62,7 @@ export default class Channel extends TabbedFeed<IBrowseResponse> {
this.subscribe_button = this.page.header_memo?.getType(SubscribeButton)[0];
if (this.page.contents)
this.current_tab = this.page.contents.item().as(TwoColumnBrowseResults).tabs.get({ selected: true });
this.current_tab = this.page.contents.item().as(TwoColumnBrowseResults).tabs.find((tab) => tab.selected);
}
/**
@@ -75,7 +75,7 @@ export default class Channel extends TabbedFeed<IBrowseResponse> {
const filter_chipbar = this.memo.getType(FeedFilterChipBar)[0];
if (typeof filter === 'string') {
target_filter = filter_chipbar?.contents.get({ text: filter });
target_filter = filter_chipbar?.contents.find((chip) => chip.text === filter);
if (!target_filter)
throw new InnertubeError(`Filter ${filter} not found`, { available_filters: this.filters });
} else {
@@ -330,7 +330,7 @@ export class FilteredChannelList extends FilterableFeed<IBrowseResponse> {
constructor(actions: Actions, data: ApiResponse | IBrowseResponse, already_parsed = false) {
super(actions, data, already_parsed);
this.applied_filter = this.memo.getType(ChipCloudChip).get({ is_selected: true });
this.applied_filter = this.memo.getType(ChipCloudChip).find((chip) => chip.is_selected);
// Removes the filter chipbar from the actions list
if (

4
src/parser/youtube/Search.ts
View File

@@ -59,7 +59,9 @@ export default class Search extends Feed<ISearchResponse> {
if (typeof card === 'string') {
if (!this.refinement_cards) throw new InnertubeError('No refinement cards found.');
target_card = this.refinement_cards?.cards.get({ query: card })?.as(SearchRefinementCard);
target_card = this.refinement_cards?.cards.find((refinement_card): refinement_card is SearchRefinementCard => {
return refinement_card.is(SearchRefinementCard) && refinement_card.query === card;
});
if (!target_card)
throw new InnertubeError(`Refinement card "${card}" not found`, { available_cards: this.refinement_card_queries });
} else if (card.type === 'SearchRefinementCard') {

4
src/parser/youtube/Settings.ts
View File

@@ -33,7 +33,7 @@ export default class Settings {
if (!this.#page.contents)
throw new InnertubeError('Page contents not found');
const tab = this.#page.contents.item().as(TwoColumnBrowseResults).tabs.get({ selected: true });
const tab = this.#page.contents.item().as(TwoColumnBrowseResults).tabs.find((tab) => tab.selected);
if (!tab)
throw new InnertubeError('Target tab not found');
@@ -58,7 +58,7 @@ export default class Settings {
let item: CompactLink | undefined;
if (typeof target_item === 'string') {
item = this.sidebar.items.get({ title: target_item });
item = this.sidebar.items.find((link) => link.title === target_item);
if (!item)
throw new InnertubeError(`Item "${target_item}" not found`, { available_items: this.sidebar_items });
} else if (target_item?.is(CompactLink)) {

16
src/parser/youtube/VideoInfo.ts
View File

@@ -131,7 +131,9 @@ export default class VideoInfo extends MediaInfo {
}
}
const comments_entry_point = results.get({ target_id: 'comments-entry-point' })?.as(ItemSection);
const comments_entry_point = results.find((node): node is ItemSection => {
return node.is(ItemSection) && node.target_id === 'comments-entry-point';
});
this.comments_entry_point_header = comments_entry_point?.contents?.firstOfType(CommentsEntryPointHeader);
this.livechat = next?.contents_memo?.getType(LiveChat)[0];
@@ -163,7 +165,7 @@ export default class VideoInfo extends MediaInfo {
let cloud_chip: ChipCloudChip;
if (typeof target_filter === 'string') {
const filter = this.related_chip_cloud?.chips?.get({ text: target_filter });
const filter = this.related_chip_cloud?.chips?.find((chip) => chip.text === target_filter);
if (!filter)
throw new InnertubeError('Invalid filter', { available_filters: this.filters });
@@ -178,9 +180,11 @@ export default class VideoInfo extends MediaInfo {
if (cloud_chip.is_selected) return this;
const response = await cloud_chip.endpoint?.call(this.actions, { parse: true });
const data = response?.on_response_received_endpoints?.get({ target_id: 'watch-next-feed' });
const data = response?.on_response_received_endpoints?.find((endpoint): endpoint is ReloadContinuationItemsCommand => {
return endpoint.is(ReloadContinuationItemsCommand) && endpoint.target_id === 'watch-next-feed';
});
this.watch_next_feed = data?.as(AppendContinuationItemsAction, ReloadContinuationItemsCommand).contents;
this.watch_next_feed = data?.contents;
return this;
}
@@ -207,12 +211,12 @@ export default class VideoInfo extends MediaInfo {
throw new InnertubeError('Watch next feed continuation not found');
const response = await this.#watch_next_continuation?.endpoint.call(this.actions, { parse: true });
const data = response?.on_response_received_endpoints?.get({ type: 'AppendContinuationItemsAction' });
const data = response?.on_response_received_endpoints?.firstOfType(AppendContinuationItemsAction);
if (!data)
throw new InnertubeError('AppendContinuationItemsAction not found');
this.watch_next_feed = data?.as(AppendContinuationItemsAction, ReloadContinuationItemsCommand).contents;
this.watch_next_feed = data?.contents;
if (this.watch_next_feed?.at(-1)?.is(ContinuationItem)) {
this.#watch_next_continuation = this.watch_next_feed.pop()?.as(ContinuationItem);
} else {

2
src/parser/ytmusic/Explore.ts
View File

@@ -20,7 +20,7 @@ export default class Explore {
constructor(response: ApiResponse) {
this.#page = Parser.parseResponse<IBrowseResponse>(response.data);
const tab = this.#page.contents?.item().as(SingleColumnBrowseResults).tabs.get({ selected: true });
const tab = this.#page.contents?.item().as(SingleColumnBrowseResults).tabs.find((tab) => tab.selected);
if (!tab)
throw new InnertubeError('Could not find target tab.');

4
src/parser/ytmusic/HomeFeed.ts
View File

@@ -23,7 +23,7 @@ export default class HomeFeed {
this.#actions = actions;
this.#page = Parser.parseResponse<IBrowseResponse>(response.data);
const tab = this.#page.contents?.item().as(SingleColumnBrowseResults).tabs.get({ selected: true });
const tab = this.#page.contents?.item().as(SingleColumnBrowseResults).tabs.find((tab) => tab.selected);
if (!tab)
throw new InnertubeError('Could not find Home tab.');
@@ -62,7 +62,7 @@ export default class HomeFeed {
let cloud_chip: ChipCloudChip | undefined;
if (typeof target_filter === 'string') {
cloud_chip = this.header?.chips?.as(ChipCloudChip).get({ text: target_filter });
cloud_chip = this.header?.chips?.as(ChipCloudChip).find((chip) => chip.text === target_filter);
if (!cloud_chip)
throw new InnertubeError('Could not find filter with given name.', { available_filters: this.filters });
} else if (target_filter?.is(ChipCloudChip)) {

2
src/parser/ytmusic/Library.ts
View File

@@ -97,7 +97,7 @@ export default class Library {
const chip_cloud = this.#page.contents_memo?.getType(ChipCloud)[0];
if (typeof filter === 'string') {
target_chip = chip_cloud?.chips.get({ text: filter });
target_chip = chip_cloud?.chips.find((chip) => chip.text === filter);
if (!target_chip)
throw new InnertubeError(`Filter "${filter}" not found`, { available_filters: this.filters });

4
src/parser/ytmusic/Search.ts
View File

@@ -32,7 +32,7 @@ export default class Search {
if (!this.#page.contents || !this.#page.contents_memo)
throw new InnertubeError('Response did not contain any contents.');
const tab = this.#page.contents.item().as(TabbedSearchResults).tabs.get({ selected: true });
const tab = this.#page.contents.item().as(TabbedSearchResults).tabs.find((tab) => tab.selected);
if (!tab)
throw new InnertubeError('Could not find target tab.');
@@ -87,7 +87,7 @@ export default class Search {
let cloud_chip: ChipCloudChip | undefined;
if (typeof target_filter === 'string') {
cloud_chip = this.header?.chips?.as(ChipCloudChip).get({ text: target_filter });
cloud_chip = this.header?.chips?.as(ChipCloudChip).find((chip) => chip.text === target_filter);
if (!cloud_chip)
throw new InnertubeError('Could not find filter with given name.', { available_filters: this.filters });
} else if (target_filter?.is(ChipCloudChip)) {

2
src/parser/ytmusic/TrackInfo.ts
View File

@@ -48,7 +48,7 @@ class TrackInfo extends MediaInfo {
throw new InnertubeError('Could not find any tab');
const target_tab =
this.tabs.get({ title: title_or_page_type }) ||
this.tabs.find((tab) => tab.title === title_or_page_type) ||
this.tabs.find((tab) => tab.endpoint.payload.browseEndpointContextSupportedConfigs?.browseEndpointContextMusicConfig?.pageType === title_or_page_type) ||
this.tabs?.[0];